telemetry(amazonq): Adding requestId for amazonq_utgGenerateTests event #6181
+10
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
justinmk3
reviewed
Dec 9, 2024
| logger.debug('target line range end: %O', firstTargetLineRangeList?.end) | ||
|
|
||
| const resp = await codewhispererClient.codeWhispererClient.startTestGeneration(req).catch((err) => { | ||
| ChatSessionManager.Instance.getSession().startTestGenerationRequestId = err.requestId |
Contributor
There was a problem hiding this comment.
so ChatSessionManager.Instance.getSession() is global, shared, mutable state?
Contributor
Author
There was a problem hiding this comment.
Yes, its global and mutable.
Contributor
There was a problem hiding this comment.
It's clear that will be a source of bugs, right? Any random codepath can update requestId at any time, and it may be completely wrong.
karanA-aws
pushed a commit
to karanA-aws/aws-toolkit-vscode
that referenced
this pull request
Jan 17, 2025
…6181 ## Problem - Missing data if job fails at `StartTestGeneration` API. ## Solution - Adding requestId for `amazonq_utgGenerateTests` event, which helps to debug the reason for job failures from the backend.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
StartTestGenerationAPI.Solution
amazonq_utgGenerateTestsevent, which helps ti debug the reason for job failures from the backend.feature/xbranches will not be squash-merged at release time.License: I confirm that my contribution is made under the terms of the Apache 2.0 license.